fix from_pretrained in_channels, etc. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added options to override dropout and drop_connect
add mish to utils
added mish as option in set_swish
|
maybe should have pushed these to another fork... but these commits add dropout and drop_connect options as well as mish (as an option in set_swish) |
fixed typo in set_swish
fixed typo in Mish
|
perhaps it's simpler to have just a from_name function and a pretrained boolean arg? |
consolidated from_name and from_pretrained
|
any update to this? facing the same issue |
|
you can use my fork for now |
thanks alot. already done that. its working great, |
|
Good to hear! let me know if you think any of the changes I made are unintuitive since I did a little more than just fixing the channels issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
from_pretrainedparamin_channelsrename existing
from_nameto_from_nameadded new
from_nameto matchfrom_pretrainedsignature